Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UISACQCOMP-124: Add handlers for search field and reset all button in PluginFindRecordModal component #652

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

OleksandrHladchenko1
Copy link
Contributor

@OleksandrHladchenko1 OleksandrHladchenko1 commented Nov 8, 2022

Purpose

  • To use react-highlight-words with ui-find-import-profile plugin, we need to add handlers when search field is changed and reset all button is clicked.

Approach

  • Added prop onSearchChange that calls when search field is changed and when Reset all button is clicked.

PR UIPFIMP-52
Ticket UISACQCOMP-124

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Jest Unit Test Statistics

    1 files  ±0  125 suites  ±0   3m 2s ⏱️ +33s
317 tests ±0  316 ✔️ ±0  1 💤 ±0  0 ±0 
323 runs  ±0  322 ✔️ ±0  1 💤 ±0  0 ±0 

Results for commit 730d07f. ± Comparison against base commit 19b4180.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 730d07f. ± Comparison against base commit 19b4180.

♻️ This comment has been updated with latest results.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@OleksandrHladchenko1 OleksandrHladchenko1 requested a review from a team November 8, 2022 14:27
@OleksandrHladchenko1 OleksandrHladchenko1 merged commit 5b9cc94 into master Nov 9, 2022
@OleksandrHladchenko1 OleksandrHladchenko1 deleted the UISACQCOMP-124 branch November 9, 2022 15:52
OleksandrHladchenko1 added a commit that referenced this pull request Nov 17, 2022
… PluginFindRecordModal component (#652)

(cherry picked from commit 5b9cc94)
OleksandrHladchenko1 added a commit that referenced this pull request Nov 18, 2022
… PluginFindRecordModal component (#652)

(cherry picked from commit 5b9cc94)
OleksandrHladchenko1 added a commit that referenced this pull request Nov 18, 2022
* UISACQCOMP-124: Add handlers for search field and reset all button in PluginFindRecordModal component (#652)

(cherry picked from commit 5b9cc94)

* Release v3.3.1

* Release v3.3.1

* Release v3.3.1

* Release v3.3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants